7 Commits (ab7f5e5401d45462f517f204e5ce52d80d7dbcd6)

Author	SHA1	Message	Date
Disconnect3d	ab7f5e5401	Fix memleak when parsing keys with embedded null bytes (#157) ... * Fix memleak when parsing key with embedded null byte This commit fixes and adds a test for a memory leak that occurs when parsing strings with keys that have a null byte embedded in them. This memory leak can be triggered with the following line, where this call returns a `NULL`: ```c json_parse_string("{\"\\u0000\"") ``` This memory leak happens in the `parse_object_value` function in here: ``` new_key = get_quoted_string(string, &key_len); <---- ALLOCATION /* We do not support key names with embedded \0 chars */ if (new_key == NULL || key_len != strlen(new_key)) { json_value_free(output_value); return NULL; <---- `new_key` NOT FREED } SKIP_WHITESPACES(string); if (**string != ':') { parson_free(new_key); json_value_free(output_value); return NULL; } ``` * Increments version to 1.1.2 Co-authored-by: Krzysztof Gabis <kgabis@gmail.com>	3 years ago
benswick	60b2c69f17	Improved serialization performance (#156) ... * Update parson.c Get objects by index instead of key in json_serialize_to_buffer_r(). * Increments version and updates licence date. Co-authored-by: Krzysztof Gabis <kgabis@gmail.com>	4 years ago
reuben olinsky	102a4467e1	Add support for string values with embedded '\0' characters (#137) ... * Add support for strings with \0 chars * address feedback * Increments minor version, adds comments, changes license year Co-authored-by: Krzysztof Gabis <kgabis@gmail.com>	5 years ago
ɹɐɯsǝʎ	186680a511	Guard against potential integer overflow (#133) ... * Guard against potential integer overflow If int res holds the value INT_MAX then adding 1 results in undefined behavior. To guard against this possibility, cast res to size_t, not the result of res + 1. Fixes #132 * Increments version. * More consitent parentheses when casting to size_t.	5 years ago
dan soucy	9d63e76014	Avoid truncating strings warning (#131) ... * Avoid truncating strings warning GCC 8 introduced the `stringop-truncation` warning, which warns for uses of `strncpy` of the form `strncpy(out, in, strlen(in))`. This is often helpful, as this call would not copy the trailing `\0`, potentially leading to subtle bugs. With optimizations enabled, the function `parson_strndup` is inlined, allowing the compiler to see that this call to `strncpy` is of the form described above. GCC therefore outputs the warning. In this case, the out buffer has already had the terminating `\0` written to the end. Thus it is not necessary to copy it. GCC 9.2 is not quite smart enough to recognize this, so it warns. The warning is silenced by using `memcpy` instead of `strncpy`. Although I have not benchmarked it, this change might reasonably improve the performance of `parson_strndup`. `strncpy` checks every byte for `\0` in addition to counting to `n`. `memcpy` does not need to check whether the bytes it copies are `\0`. However, if `parson_strndup` is frequently passed `char *`s with a `\0` somewhere in the middle, then `memcpy` will copy more bytes than necessary, hurting performance. In this case, a better solution might be: ``` - output_string[n] = `\0`; - strncpy(output_string, string, n); + strncpy(output_string, string, n+1); ``` * Increments parson's version.	5 years ago
Matthias Schoepfer	da126c2aba	CMakeLists.txt: Minimal fixes, added GNUInstallDirs and fixed cmake config loc ... Also set version for proper shared lib Signed-off-by: Matthias Schoepfer <matthias.schoepfer@ithinx.io>	5 years ago
Ewerton Scaboro da Silva	74ea152aa7	Add CMakeLists.txt with install definitions	5 years ago