AIR/tiny-json
1
0
Fork 0
mirror of https://github.com/rafagafe/tiny-json.git synced 2025-03-12 19:25:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed strcmp and replaced with strncmp to prevent buffer overruns.

Browse Source 
This forced the definition of a MAX_PROPERTY_SIZE arbitrarily chosen of 64
This commit is contained in:
Ignacio Bortolazzi 2021-04-17 12:08:08 +02:00
parent 7b52f29410
commit 847177d9f9
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tiny-json.c
View File

@ -30,6 +30,8 @@
#include <string.h>
#include <ctype.h>
#include "tiny-json.h"
#include <stdio.h>
#define MAX_PROPERTY_SIZE 64
/** Structure to handle a heap of JSON properties. */
typedef struct jsonStaticPool_s {
@ -43,9 +45,15 @@ typedef struct jsonStaticPool_s {
json_t const* json_getProperty( json_t const* obj, char const* property ) {
json_t const* sibling;
for( sibling = obj->u.c.child; sibling; sibling = sibling->sibling ){
if ( sibling->name && !strcmp( sibling->name, property ) ){
return sibling;
if (strlen(property)>MAX_PROPERTY_SIZE)
{
return 0;
}
else{
if ( sibling->name && !strncmp( sibling->name, property,MAX_PROPERTY_SIZE) ){
return sibling;
}
}
}
return 0;
}
@ -358,7 +366,7 @@ static char* numValue( char* ptr, json_t* property ) {
char const tmp = *ptr;
char const* const threshold = negative ? min: max;
*ptr = '\0';
if ( 0 > strcmp( threshold, value ) ){
if ( 0 > strncmp( threshold, value, len) ){
return 0;
}
*ptr = tmp;